JS: Avoid overriding Expr predicates in xUnit.qll #20317
Merged
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
added
no-change-note-required
There was a problem hiding this comment.
Pull Request Overview
This PR removes overridden implementations of getFirstToken and getLastToken predicates in the xUnit.qll library to avoid problematic dependencies for overlay locality. The change introduces separate root definitions for custom interpretations of these predicates instead of overriding common definitions.
- Introduces a
FinalExprtype alias to avoid inheritance conflicts - Adds explicit
getFirstTokenandgetLastTokenmethods toBracketedListOfExpressionsclass - Refactors
ArrayExprIsABracketedListOfExpressionsto use instance-of syntax instead of direct inheritance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/ql/lib/semmle/javascript/frameworks/xUnit.qll | Refactored inheritance structure and added explicit token accessor methods |
| javascript/ql/test/library-tests/frameworks/xUnit/tests.expected | Updated test expectations to reflect changes in token positioning |
Napalys
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XUnit family of library models contained an override of
getFirstTokenandgetLastToken. Overriding the common definitions was not actually necessary, and induced some dependencies that are problematic for overlay locality.This PR removes the problematic dependency by introducing separate root-defs for the custom interpretation of these predicates.